Skip to content

Conversation

norbertprokopiuk
Copy link

Version 2.0.0 of the standard introduced message type Resource. LoadWorld.srv uses for request the same data types as defined in Resource.msg rather than using Resource datatype.

This PR replaces string uri and string resource_string with Resource. Change is made in the same manner as in SpawnEntity.srv during release of the version 2.0.0.

@adamdbrw adamdbrw requested a review from azeey August 4, 2025 13:40
norbertprokopiuk and others added 2 commits August 4, 2025 15:43
Signed-off-by: Norbert Prokopiuk <[email protected]>
* solve uncrustify style divergence:
Code style divergence in file '/tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h':

--- /tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h
+++ /tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h.uncrustify
@@ -35 +35 @@
-  * and, depending on the simulator, loaded from local or remote repositories.
+  * and, depending on the simulator, loaded from local or remote repositor[chore] formatting fix

Signed-off-by: Mateusz Żak <[email protected]>
Copy link
Member

@ayushgnv ayushgnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
Please see the previous comment.

Copy link
Member

@ayushgnv ayushgnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants